Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'cached_block_indices' method in DataCache trait #607

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

dannycjones
Copy link
Contributor

Description of change

This method (for caching) was no longer used, let's remove it.

Relevant issues: #255

Does this change impact existing behavior?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dannycjones dannycjones temporarily deployed to PR integration tests November 15, 2023 15:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 15, 2023 15:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 15, 2023 15:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 15, 2023 15:04 — with GitHub Actions Inactive
@dannycjones dannycjones added this pull request to the merge queue Nov 16, 2023
Merged via the queue into awslabs:main with commit 52dfe29 Nov 16, 2023
18 checks passed
@dannycjones dannycjones deleted the remove-cached-block-indicies branch November 16, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants