Use a unique target for request spans #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These spans are emitted at a high level (WARN), which is annoying for clients that want to use an adapter to the `log` facade, where `tracing` will emit an event whenever a span is created. To help these clients filter out these span events, let's use a unique target for them. I verified that log messages for requests are still emitting this span metadata when Mountpoint requests log, so this only affects clients that aren't using `tracing`. Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
These spans are emitted at a high level (WARN), which is annoying for clients that want to use an adapter to the
logfacade, wheretracingwill emit an event whenever a span is created. To help these clients filter out these span events, let's use a unique target for them.I verified that log messages for requests are still emitting this span metadata when Mountpoint requests log, so this only affects clients that aren't using
tracing.Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).