Cleanup cache dir at mount and exit #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
requested changes
Nov 21, 2023
| } | ||
|
|
||
| /// Create an owned copy of the managed path | ||
| pub fn as_path_buf(&self) -> PathBuf { |
There was a problem hiding this comment.
This seems unnecessary. Can't you do something like .as_path().to_owned() if required?
There was a problem hiding this comment.
We can, but I found we were doing that a few times and it felt more ergonomic to just add the method here.
There was a problem hiding this comment.
I've left this in for now. We do use it at the moment.
There was a problem hiding this comment.
I still think we should remove. But not a blocker.
Signed-off-by: Daniel Carl Jones <[email protected]>
… to FuseSession Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
approved these changes
Nov 21, 2023
| @@ -597,6 +601,14 @@ fn mount(args: CliArgs) -> anyhow::Result<FuseSession> { | |||
| fuse_config, | |||
| &bucket_description, | |||
| ); | |||
There was a problem hiding this comment.
nit: could just ? here and simplify the rest
| } | ||
|
|
||
| /// Create an owned copy of the managed path | ||
| pub fn as_path_buf(&self) -> PathBuf { |
There was a problem hiding this comment.
I still think we should remove. But not a blocker.
|
Merging as is for now, happy to revisit some nits later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We want to clean the directory used for caching at mount time and exit time to keep usage of the disk under control, especially since we do not intend to support cache re-use (at least initially).
This change adds a new managed directory type, which will create the directory we expect and deleted it on drop, if
close(mut self)was not already called. We introduceclosesince the drop implementation did not appear to always be invoked.Relevant issues: #255
Does this change impact existing behavior?
No change to released features. Only impacts caching, currently behind a feature flag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).