Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRT submodules to latest releases #633

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

dannycjones
Copy link
Contributor

Description of change

Pulling in the latest changes.

9e11ad8 Update CRT submodules to latest releases
Submodule mountpoint-s3-crt-sys/crt/aws-c-auth 71bad38..50f3e0d:
  > Add an Option to Disable v2 to v1 Fallback (#218)
Submodule mountpoint-s3-crt-sys/crt/aws-c-common fefbf4b..80f21b3:
  > Fixed directory creation to ignore umask, and allow cross process loc… (#1078)
Submodule mountpoint-s3-crt-sys/crt/aws-c-io c9cb777..df64f57:
  > Use 500ms rather than 25ms for the exponential backoff defaults. (#612)
  > Remove null check for aws_pkcs11_lib_login_user (#611)
Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 83008e5..cc6ba34:
  > Report S3 operation name of specific request that failed. (#377)
  > Auto - Update S3 Ruleset & Partition (#376)
  > Mem limiter (#368)
  > fix stale bot permissions (#371)
Submodule mountpoint-s3-crt-sys/crt/aws-lc a8d06de..80f3f33:
  > Bump release version number string to 1.17.4 (#1319)
  > Improve Codecov reporting (#1313)
  > Merge pull request #1314 from torben-hansen/aws-lc-s2n-bignum-update-2023-11-19
  > Merge pull request #1308 from torben-hansen/aws-lc-s2n-bignum-update-2023-11-15
  > Add BNAssertTest (#1267)
  > Silence warning on CMP0116 (#1284)
  > Use OPENSSL_DEPRECATED (#1285)
  > Add integration ci for Monit (#1286)
  > Include Codecov in CI (#1307)
  > Fix bn_assert_fits_in_bytes for big-endian (#1258)
  > Fix-up curve25519 code to prepare for s2n-bignum (#1306)
  > Merge pull request #1302 from samuel40791765/upstream-merge-2023-11-10
  > Add check for sk_X509_push (#1304)
  > Refactor ED25519_verify into hw and nohw backend (#1305)
  > Add back OCSP integration test executing (#1303)
  > Refactor ED25519_sign into hw and nohw backend (#1276)
  > Add HybridKeyShare support for SecP256r1Kyber768Draft00 and X25519Kyber768Draft00 (#1201)

Relevant issues: N/A

Does this change impact existing behavior?

This change inherits a change of default when constructing a CRT client using mountpoint-s3-crt, however mountpoint-s3-client already sets its own defaults and is unaffected.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 10:57 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 10:57 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 10:57 — with GitHub Actions Inactive
@dannycjones dannycjones changed the title Update crt Update CRT submodules to latest releases Nov 27, 2023
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 11:43 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 11:43 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 11:43 — with GitHub Actions Inactive
Signed-off-by: Daniel Carl Jones <[email protected]>
monthonk
monthonk previously approved these changes Nov 27, 2023
@monthonk monthonk enabled auto-merge November 27, 2023 15:25
@monthonk monthonk added this pull request to the merge queue Nov 27, 2023
@passaro passaro removed this pull request from the merge queue due to a manual request Nov 27, 2023
@dannycjones dannycjones marked this pull request as draft November 27, 2023 16:26
@dannycjones
Copy link
Contributor Author

We should update our bindings based on awslabs/aws-c-s3@cc6ba34.

Signed-off-by: Daniel Carl Jones <[email protected]>
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 17:02 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 17:02 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 17:02 — with GitHub Actions Inactive
@dannycjones dannycjones marked this pull request as ready for review November 27, 2023 17:02
@dannycjones dannycjones requested a review from monthonk November 27, 2023 17:04
monthonk
monthonk previously approved these changes Nov 27, 2023
Copy link
Contributor

@monthonk monthonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can see the metrics on my test instance.

@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 20:20 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 20:20 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests November 27, 2023 20:20 — with GitHub Actions Inactive
Signed-off-by: Daniel Carl Jones <[email protected]>
@monthonk monthonk added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2023
@dannycjones dannycjones added this pull request to the merge queue Nov 28, 2023
Merged via the queue into awslabs:main with commit c3521f3 Nov 28, 2023
18 checks passed
@dannycjones dannycjones deleted the update-crt branch November 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants