Add FileName/Object key in error logging #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
force-pushed
the
filename_in_error
branch
from
c0c74e0 to
6c2f14b
Compare
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
added 4 commits
November 30, 2023 02:51
Signed-off-by: Ankit Saurabh <[email protected]>
Signed-off-by: Ankit Saurabh <[email protected]>
Signed-off-by: Ankit Saurabh <[email protected]>
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
force-pushed
the
filename_in_error
branch
from
a511fcd to
266d93b
Compare
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
changed the title
|
Closing this PR as new PR #665 is implemented in a new way to log filename in error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
InodeErroris logged mutliple times directly at error level. So, added Filename in FileDoesNotExist type. Could not add InodeErrorInfo for InodeDoesNotExist error type because it is called by get() ofSuperBlockInner. It only has Inode number as a parameter.Also added object key in UploadWriteError types.
For rest of the errors added object key wherever it was available.
Relevant issues:
#555
Does this change impact existing behavior?
No, it does not impact existing behaviour.
No breaking changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).