Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRT submodules to latest releases #652

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Update CRT submodules to latest releases #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baafd74
Update CRT submodules to latest releases (aws-c-s3 0.4.3)
passaro Nov 30, 2023
83f388d
Update S3CrtClient test to reflect loosened part size constraint
passaro Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions mountpoint-s3-client/src/s3_crt_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,10 +1034,9 @@ mod tests {
use super::*;
use test_case::test_case;

/// Test both explicit validation in [Client::new] and implicit limits in the CRT
#[test_case(4 * 1024 * 1024; "less than 5MiB")] // validated in Client::new
#[test_case(10_000_000; "not a multiple of 1024")] // CRT constraint
#[test_case(6 * 1024 * 1024 * 1024; "greater than 5GiB")] // validated in Client::new
/// Test explicit validation in [Client::new]
#[test_case(4 * 1024 * 1024; "less than 5MiB")]
#[test_case(6 * 1024 * 1024 * 1024; "greater than 5GiB")]
fn client_new_fails_with_invalid_part_size(part_size: usize) {
let config = S3ClientConfig {
part_size,
Expand Down
2 changes: 1 addition & 1 deletion mountpoint-s3-crt-sys/crt/aws-c-s3
Open in desktop
Submodule aws-c-s3 updated 11 files
+3 −0 include/aws/s3/private/s3_buffer_pool.h
+1 −0 include/aws/s3/s3.h
+2 −0 source/s3.c
+36 −14 source/s3_buffer_pool.c
+56 −24 source/s3_client.c
+1 −0 source/s3express_credentials_provider.c
+13 −8 tests/CMakeLists.txt
+31 −0 tests/s3_buffer_pool_tests.c
+2 −1 tests/s3_data_plane_tests.c
+1 −4 tests/s3_mock_server_s3express_provider_test.c
+167 −7 tests/s3_s3express_client_test.c
Loading