Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo cache from the Address Sanitizer tests in Github CI #744

Closed
wants to merge 1 commit into from

Conversation

sauraank
Copy link
Contributor

@sauraank sauraank commented Feb 9, 2024

Description of change

Our Github CI is failing due Address Sanitizer job is running out of device space: https://github.com/awslabs/mountpoint-s3/actions/runs/7832124518/job/21394015887?pr=742
So, I am removing the restore cache and save cache step to reduce disk space usage.

Relevant issues:
NA

Does this change impact existing behavior?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@sauraank sauraank temporarily deployed to PR integration tests February 9, 2024 13:42 — with GitHub Actions Inactive
@monthonk
Copy link
Contributor

monthonk commented Feb 9, 2024

Does this mean the cache size is bigger than expected? I thought that building from scratch vs with cache would result in the same artifacts. Did you test it somewhere?

@passaro
Copy link
Contributor

passaro commented Mar 15, 2024

A similar change has already been merged as part of #814 .

@passaro passaro closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants