chore(interchain-token-service): verify input validation #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prohibit deploying token with negative supply - minor cleanup on docstring
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 62 62
Lines 3593 3595 +2
=======================================
+ Hits 3429 3431 +2
Misses 164 164 ☔ View full report in Codecov by Sentry. |
milapsheth
approved these changes
Jan 24, 2025
| @@ -229,6 +229,8 @@ impl InterchainTokenServiceInterface for InterchainTokenService { | |||
|
|
|||
| caller.require_auth(); | |||
|
|
|||
| ensure!(initial_supply >= 0, ContractError::InvalidSupply); | |||
There was a problem hiding this comment.
no minter and 0 initial supply is a weird case that we can check for too
ahramy
reviewed
Jan 24, 2025
| /// Returns `ContractError` if the deployment fails, the token ID is invalid, or token metadata is invalid. | ||
| /// - `ContractError::InvalidDestinationChain`: If the `destination_chain` is the current chain. | ||
| /// - `ContractError::InvalidTokenId`: If the token ID is invalid. | ||
| /// - Errors propagated from `token_metadata`. |
There was a problem hiding this comment.
nit: Is this necessary? If so, we need to update similar docstrings for other functions for consistency.
There was a problem hiding this comment.
It's consistent with the rest of the ITS docstring
ahramy
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-7246