Skip to content

Commit

Permalink
Update ERDDAP to 2.25.1
Browse files Browse the repository at this point in the history
See also #91

Co-authored-by: Filipe Fernandes <[email protected]>
  • Loading branch information
srstsavage and ocefpaf committed Dec 19, 2024
1 parent 9ef83b7 commit 6a7f85a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG BASE_IMAGE=tomcat:10.1.26-jdk21-temurin-jammy
#referencing a specific image digest pins our unidata tomcat-docker image to platform amd64 (good)
ARG UNIDATA_TOMCAT_IMAGE=unidata/tomcat-docker:10-jdk17@sha256:af7d3fecec753cbd438f25881deeaf48b40ac1f105971d6f300252e104e39fb2
FROM ${UNIDATA_TOMCAT_IMAGE} as unidata-tomcat-image
FROM ${UNIDATA_TOMCAT_IMAGE} AS unidata-tomcat-image

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build and test Docker Image (linux/arm64/v8, jdk21-openjdk, tomcat:10.1.26-jdk21-temurin-jammy@sh...

Base image platform does not match expected target platform

InvalidBaseImagePlatform: Base image unidata/tomcat-docker:10-jdk17@sha256:af7d3fecec753cbd438f25881deeaf48b40ac1f105971d6f300252e104e39fb2 was pulled with platform "linux/amd64", expected "linux/arm64" for current build
FROM ${BASE_IMAGE}

#use approaches and hardened files from https://github.com/Unidata/tomcat-docker
Expand Down Expand Up @@ -39,9 +39,10 @@ COPY --from=unidata-tomcat-image ${CATALINA_HOME}/conf/web.xml ${CATALINA_HOME}/
# Security enhanced server.xml
COPY --from=unidata-tomcat-image ${CATALINA_HOME}/conf/server.xml ${CATALINA_HOME}/conf/

ARG ERDDAP_VERSION=2.24
ARG ERDDAP_CONTENT_URL=https://github.com/ERDDAP/erddap/releases/download/v$ERDDAP_VERSION/erddapContent.zip
ARG ERDDAP_WAR_URL=https://github.com/ERDDAP/erddap/releases/download/v$ERDDAP_VERSION/erddap.war
ARG ERDDAP_VERSION=2.25.1
ARG ERDDAP_CONTENT_VERSION=1.0.0
ARG ERDDAP_WAR_URL="https://github.com/ERDDAP/erddap/releases/download/v${ERDDAP_VERSION}/erddap.war"
ARG ERDDAP_CONTENT_URL="https://github.com/ERDDAP/erddapContent/archive/refs/tags/content${ERDDAP_CONTENT_VERSION}.zip"
ENV ERDDAP_bigParentDirectory /erddapData

Check warning on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build and test Docker Image (linux/amd64, jdk21-openjdk, tomcat:10.1.26-jdk21-temurin-jammy@sha25...

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build and test Docker Image (linux/arm64/v8, jdk21-openjdk, tomcat:10.1.26-jdk21-temurin-jammy@sh...

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN apt-get update && apt-get install -y unzip xmlstarlet \
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ A feature full Tomcat (SSL over APR, etc.) running [ERDDAP](http://coastwatch.pf

Most recent versions:

* `axiom/docker-erddap:latest-jdk21-openjdk` (2.24)
* `axiom/docker-erddap:latest-jdk21-openjdk` (2.25.1)
* `axiom/docker-erddap:2.25.1-jdk21-openjdk`
* `axiom/docker-erddap:2.24-jdk21-openjdk`
* `axiom/docker-erddap:2.23-jdk17-openjdk`

Expand Down

0 comments on commit 6a7f85a

Please sign in to comment.