Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest rust stable, adopt pendantic clippy, other tidyings #13

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Update to latest rust stable, adopt pendantic clippy, other tidyings #13

merged 10 commits into from
Nov 30, 2023

Conversation

darach
Copy link
Contributor

@darach darach commented Oct 20, 2023

  • Adopts pedantic clippy
  • Removes panics from critical path
  • Adds with_tags to builder for user defined resources
  • Makes the functional test a demo
  • Update dependencies
  • Hardens checking for required variables for token, dataset
  • Adds deny for SBOM and license checks
  • Minor code coverage enhancements

@darach darach requested a review from bahlo October 20, 2023 13:08
@darach darach enabled auto-merge October 20, 2023 13:09
@darach
Fix doctests to reflect stricter environment variable checks and don'…
9a2edaf 
…t run illustrative examples in CI

Signed-off-by: Darach Ennis <[email protected]>
bahlo
bahlo reviewed Oct 23, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
darach and others added 5 commits October 23, 2023 16:42
@ewrogers
Copy link

ewrogers commented Nov 5, 2023

These changes would definitely be nice, namely not needing the Guard to be returned back and held by the outer main function.

Anything holding this up from release?

@ewrogers ewrogers mentioned this pull request Nov 10, 2023
Closed
@darach darach disabled auto-merge November 30, 2023 11:55
@darach darach enabled auto-merge November 30, 2023 12:51
bahlo
bahlo approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@darach darach merged commit 856eb82 into main Nov 30, 2023
@darach darach deleted the obey-pedantic-clippy branch November 30, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahlo bahlo bahlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darach @ewrogers @bahlo