Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to newest otel libs and rust 1.76 #19

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Update to newest otel libs and rust 1.76 #19

merged 5 commits into from
Mar 12, 2024

Conversation

Licenser
Copy link
Contributor

@Licenser Licenser commented Mar 6, 2024

A bunch of updates for the newest otel and rust 1.76 ideomatic code main changes are:

  • Update tracing to newest libs
  • use and_then to avoide needing to implement chaining manually on layers
  • use match! in test to avoid PartialEq on errors
  • update enviroment variable handling to allow overwriting URL
  • include /api in default url to allow local testing
  • include shutdown in examples so we don't have to hardcode it
  • tidy cargo.toml
  • move examples to be runnable via cargo run --example ...
  • change error env var error type to 'static str to avoide need for allocations

@Licenser Licenser requested review from darach and bahlo March 6, 2024 16:49
darach
darach approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like! Very nice set of udpates 🎈

darach
darach approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like! Very nice set of udpates 🎈

Licenser
Licenser commented Mar 12, 2024
View reviewed changes
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
examples/noenv/main.rs Outdated Show resolved Hide resolved
bahlo
bahlo approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Licenser Licenser enabled auto-merge March 12, 2024 14:50
@Licenser Licenser merged commit c12130a into axiomhq:main Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach darach approved these changes

@bahlo bahlo bahlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Licenser @darach @bahlo