fix: support subdirectories for additional pages paths #469

shadows-withal · 2023-06-27T11:50:06Z

{
  "build": {
    "additional_pages": {
      "Subpage": "subdir/mypage.md",
    }
  }
}

now builds and links to a page at yoursiteurl.com/subdir/mypage. Closes #448.

we do not actually support this, i'm not sure why it worked (i think the test was broken)

ashleygwilliams

some small things, might just need to understand better

src/site/layout/header.rs

src/site/page/mod.rs

src/site/page/source.rs

tests/build/fixtures/oranda_config.rs

ashleygwilliams

🙏

shadows-withal force-pushed the fix/correct-paths branch from 1942513 to b179806 Compare June 27, 2023 11:52

fix: support subdirectories for additional pages paths

c467df9

shadows-withal force-pushed the fix/correct-paths branch 2 times, most recently from f563390 to daa279a Compare June 27, 2023 17:12

test: don't pull remote additional page

e2eaa5f

we do not actually support this, i'm not sure why it worked (i think the test was broken)

shadows-withal force-pushed the fix/correct-paths branch from daa279a to e2eaa5f Compare June 27, 2023 17:14

ashleygwilliams reviewed Jun 27, 2023

View reviewed changes

src/site/layout/header.rs Show resolved Hide resolved

src/site/page/mod.rs Show resolved Hide resolved

src/site/page/source.rs Outdated Show resolved Hide resolved

src/site/page/source.rs Outdated Show resolved Hide resolved

tests/build/fixtures/oranda_config.rs Show resolved Hide resolved

fix: refactor get_filename_with_dir to return result

8c075c3

ashleygwilliams approved these changes Jun 27, 2023

View reviewed changes

shadows-withal merged commit 791ad1a into main Jun 27, 2023

shadows-withal deleted the fix/correct-paths branch June 27, 2023 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: support subdirectories for additional pages paths #469

fix: support subdirectories for additional pages paths #469

shadows-withal commented Jun 27, 2023

ashleygwilliams left a comment

ashleygwilliams left a comment

fix: support subdirectories for additional pages paths #469

fix: support subdirectories for additional pages paths #469

Conversation

shadows-withal commented Jun 27, 2023

ashleygwilliams left a comment

Choose a reason for hiding this comment

ashleygwilliams left a comment

Choose a reason for hiding this comment