Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterx expr constructor improvements #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Jan 7, 2025

Next out of #434, this time it is based on #444 that needs to go in first.

There are two patches here (on top of #444):

  • the nullv style constructors are reimplemented as a "delta" to the normal constructor to avoid code duplication
  • _eval() methods are renamed everywhere so it's easier to read perf stackdumps

@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch from 1789f6e to c51dfbc Compare January 11, 2025 11:47
@alltilla alltilla self-requested a review January 14, 2025 10:38
@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch from c51dfbc to a1a32a9 Compare January 17, 2025 09:20
bazsi added 2 commits January 18, 2025 08:30
To make it easier to understand stackdumps.

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the filterx-expr-constructor-improvements branch from a1a32a9 to 8e44174 Compare January 18, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant