Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate document for Approval decision utils #3

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

nntthuy-axonivy
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 3200f07. ± Comparison against base commit 4143c76.

♻️ This comment has been updated with latest results.

@nntthuy-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger, I created this pull request for the documentation step.
Could you help review this README.md file, it describes the purposes and implementation of Approval decision utils.
Thanks!

@ivy-sgi
Copy link
Member

ivy-sgi commented Mar 19, 2024

Hi @nntthuy-axonivy !
For the publishing of a marketplace item, it is important that the structure specified in the README.md template https://github.com/axonivy-market/market-product/blob/master/MY-PRODUCT-NAME-product/README.md is not changed, as the Readme.md is not only displayed on github, but is also automatically processed and displayed in various places (e.g. the tabs for a product on the marketplace website, e.g. here: https://market.axonivy.com/a-trust). Could you please contact the developer in Team Atomic and ask for an adjustment of the documentation?

@andreasbalsiger FYI

@nntthuy-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger @ivy-sgi, Atomic team has adapted Readme file same as the template. Please have a look on this pull request of Approval Decision Utils. Thank you!

FYI @nvvi

Copy link

@andreasbalsiger andreasbalsiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andreas' marketing pimp your market item input :)

approval-decision-utils-product/README.md Outdated Show resolved Hide resolved
approval-decision-utils-product/README.md Outdated Show resolved Hide resolved
@nntthuy-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger , I've just pushed a new commit to incorporate the feedback you gave. Could you please review the revised README file again? Thank you!

FYI @nvvi

Copy link

@andreasbalsiger andreasbalsiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it again. Thanks for making my edits. good to go!

@nntthuy-axonivy nntthuy-axonivy merged commit 3758290 into master Mar 27, 2024
1 of 4 checks passed
@nntthuy-axonivy nntthuy-axonivy deleted the feature/document branch March 27, 2024 08:28
nntthuy-axonivy pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants