Onboard UPS Connector to Axon-ivy market #1

ndkhanh-axonivy · 2024-01-03T11:43:18Z

No description provided.

…-documentation chore: polish doc & move images to folder

ndkhanh-axonivy · 2024-01-03T11:45:53Z

Hi @ny-huynh, @ptanhaxon,
Thank you so much for your amazing contribution!
As discussed via mail "Connector publishing", I fork the code from your repo https://github.com/axonivy-professional-services/ups-modules to my market repo and created this pull request for onboarding new connector.

I will start reviewing the product now, if I find any concerns or questions, I will mention you in the comment section. Thanks for your understanding!

FYI @ivy-sgi

ndkhanh-axonivy · 2024-01-04T04:31:52Z

Please add product.json for ups-connector-product

Refinement

ndkhanh-axonivy

Hi @ny-huynh, @ptanhaxon, could you please check these comment?
Thank you!

.gitignore

ups-connector-demo/src/UpsBean.java

ups-connector-demo/src_hd/ups/connector/demo/Address/Address.xhtml

ups-connector-demo/src_hd/ups/connector/demo/PickupCancel/PickupCancel.xhtml

ups-connector-demo/webContent/layouts/includes/progress-loader.xhtml

ndkhanh-axonivy · 2024-01-05T03:25:11Z

ups-connector-demo/webContent/layouts/includes/exception.xhtml

Please check the tab indent and reformat this file.

ups-connector-demo/webContent/layouts/includes/exception-details.xhtml

ups-connector-demo/webContent/layouts/basic-10.xhtml

refactor: format code and remove unused code

ndkhanh-axonivy

Hi @ny-huynh , @ptanhaxon , thank you so much for handle some previous feedbacks. and I also add new comments below, please check it.
Best regards

ups-oauth-feature/src/com/ups/auth/OAuth2Feature.java

ups-connector/config/variables.yaml

ups-connector-test/src/com/axonivy/connector/ups/UPSMock.java

ndkhanh-axonivy · 2024-01-05T05:01:02Z

ups-connector-test/src/com/axonivy/connector/ups/UPSMock.java

Could you consider to remove the json hard code or give me your reason for this?
Thank you

It is mock data for testing the connector

Sorry for the misunderstanding; of course, I know what it is. What I mentioned is moving the JSON values to a separate JSON file so that we could load it in this class. I see two advantages for doing this: first, it will avoid duplicate code, and second, the class would be cleaner.

I know, IMO the JSON is quite simple and it could be easy to read, I already separated the large one into a file so it's not a problem
As you can see the Twitter connector also does the same thing

ups-connector/config/rest-clients.yaml

ups-connector/dataclasses/ups/connector/AddressValidationData.ivyClass

…rest client config

ndkhanh-axonivy

Hi @ny-huynh and @ptanhaxon , thank you for addressing our feedback in the last request. We have recently added new comments, so please take a moment to review them.

ndkhanh-axonivy · 2024-01-08T07:33:36Z

ups-connector/processes/AddressValidation.p.json

Hi @ny-huynh , could we add the error boundary for each rest client activity?
Thank you!

ndkhanh-axonivy · 2024-01-08T07:38:24Z

ups-connector/processes/AddressValidation.p.json

+        "callSignature" : "addressValidation",
+        "input" : {
+          "params" : [
+            { "name" : "requestoption", "type" : "Integer" },


Hi @ny-huynh , could you please change the names of some variables that weren't good? For example, change 'requestoption' to 'requestOption'.
Please make similar changes for the remaining variables.

ndkhanh-axonivy · 2024-01-08T07:44:45Z

ups-connector/processes/Locator.p.json

+          "reqOption" : "in.reqOption",
+          "version" : "in.version"
+        },
+        "resultType" : "com.ups.wwwcie.api.client.LOCATORResponseWrapper"


The name of variable type should be 'LocatorResponseWrapper'.

ndkhanh-axonivy · 2024-01-08T07:46:47Z

ups-connector/processes/Locator.p.json

+        "clientId" : "392a25b1-ff85-48ae-95cb-44dddd4a876b",
+        "method" : "POST",
+        "queryParams" : {
+          "Locale" : "in.locale"


The name of param should be 'locale'.

refactor: change to normal property to avoid encoded the variable on rest client config

nqhoan-axonivy · 2024-01-09T05:10:59Z

pom.xml

+  <groupId>com.axonivy.connector.ups</groupId><!-- your group id: e.g. com.axonivy.connector.<myconnector> or com.axonivy.utils.<myutil> -->
+  <name>ups-connector</name><!-- fill your product name -->
+  <artifactId>ups-connector-modules</artifactId><!-- fill your product name + a "-modules" postfix -->
+  <version>10.0.14-SNAPSHOT</version><!-- identicate your minimal compliant ivy version with the first 2 digits -->


please remove the hint in this pom? that hint supports we input the value after finishing we should remove it. Thanks! @ny-huynh

nqhoan-axonivy · 2024-01-09T06:43:28Z

ups-connector-demo/src/UpsBean.java

Please create a package for it, and follow up with your maven group id, e.g: com.axonivy.connector.ups
Thanks! @ny-huynh
Hints: Hi @ny-huynh could you help to check all files of project to make sure we have the right package name for them

nqhoan-axonivy · 2024-01-09T06:45:54Z

ups-connector-demo/src_hd/ups/connector/demo/Address/Address.xhtml

+	xmlns:p="http://primefaces.org/ui"
+	xmlns:pe="http://primefaces.org/ui/extensions">
+<h:body>
+	<ui:composition template="/layouts/basic-10.xhtml">


please use iframe-10 template, thanks! @ny-huynh

nqhoan-axonivy · 2024-01-09T06:48:21Z

ups-connector-demo/src_hd/ups/connector/demo/Address/AddressData.ivyClass

+regionalrequestindicator String #field
+regionalrequestindicator PERSISTENT #fieldModifier
+maximumcandidatelistsize Integer #field
+maximumcandidatelistsize PERSISTENT #fieldModifier


this property name is not consistent with another name of this class, we have 2 styles inside 1 data class - camelcase and lowercase => please unify it. Thanks! @ny-huynh

refactor: use frame-10 template, update property name, use variable

fix: update project build plugin version

ndkhanh-axonivy · 2024-01-10T11:38:48Z

Hi @andreasbalsiger, could you help to review this README file?
FYI this is the guideline for the ups connector.
Thanks!

refactor: update package name, format code

ny-huynh and others added 9 commits October 26, 2023 11:00

Initial commit

06987cd

feat: add rest client to call UPS API

c72b0ee

feat: add tracking demo

cf3455b

Finalize demo of UPS

161a120

update pom.xml

c0756e0

add JUnit Test for ups connector

675f0af

chore: polish doc & move images to folder

db7a6a6

Merge pull request #1 from axonivy-professional-services/chore/polish…

d60376e

…-documentation chore: polish doc & move images to folder

Merge remote-tracking branch 'remote/master'

475aeb8

ndkhanh-axonivy mentioned this pull request Jan 3, 2024

Onboard UPS Connector to Axon-ivy market axonivy-market/market#338

Closed

15 tasks

ndkhanh-axonivy changed the title ~~UPS Connector to Axon-ivy market~~ Onboard UPS Connector to Axon-ivy market Jan 3, 2024

ptanhaxon and others added 6 commits January 4, 2024 13:49

chore: Update product.json & group id, project version

19c4a71

fix: Correct version

65165e6

chore: Adjust product component

b6822fc

fix: update version

f5e0dd0

fix: update version

d4f61ce

Merge pull request #1 from ndkhanh-axonivy/chore/polish-document

8a55716

Refinement

ndkhanh-axonivy commented Jan 5, 2024

View reviewed changes

ny-huynh added 2 commits January 5, 2024 10:15

refactor: format code and remove unused code

53f8e51

update pom.xml add oauth module

20fa3dc

ndkhanh-axonivy commented Jan 5, 2024

View reviewed changes

ny-huynh and others added 2 commits January 5, 2024 11:18

remove line space

6593976

Merge pull request #2 from ndkhanh-axonivy/chore/refactor-code

b4571aa

refactor: format code and remove unused code

ndkhanh-axonivy commented Jan 5, 2024

View reviewed changes

ny-huynh added 2 commits January 5, 2024 16:31

refactor: change to normal property to avoid encoded the variable on …

412e6dc

…rest client config

fix: correct parameter in process after changing variable name

9a541cb

ndkhanh-axonivy commented Jan 8, 2024

View reviewed changes

Merge pull request #3 from ndkhanh-axonivy/chore/refactor-code

2bc21b1

refactor: change to normal property to avoid encoded the variable on rest client config

nqhoan-axonivy reviewed Jan 9, 2024

View reviewed changes

ny-huynh and others added 6 commits January 9, 2024 13:49

refactor: add variable for Auth base URL

0001569

refactor: use frame-10 template, update property name

40c657f

Merge pull request #4 from ndkhanh-axonivy/chore/refactor-code

563e039

refactor: use frame-10 template, update property name, use variable

fix: update project build plugin version

b2358e0

Merge pull request #5 from ndkhanh-axonivy/chore/refactor-code

55e5d3e

fix: update project build plugin version

Remove pattern project

bd27293

ny-huynh and others added 6 commits January 15, 2024 10:57

refactor: update package name, format code

2381c3e

fix: correct OAuth feature location on rest client

c468b72

refactor: add connector tags, change version in pom.xml

751ecc2

refactor: add tag for demo project

d8385c2

Merge pull request #6 from ndkhanh-axonivy/chore/refactor-code

68b11b6

refactor: update package name, format code

update project build plugin version (#7)

11d2f02

ndkhanh-axonivy merged commit 22e899b into axonivy-market:master Feb 22, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboard UPS Connector to Axon-ivy market #1

Onboard UPS Connector to Axon-ivy market #1

ndkhanh-axonivy commented Jan 3, 2024

ndkhanh-axonivy commented Jan 3, 2024

ndkhanh-axonivy commented Jan 4, 2024

ndkhanh-axonivy left a comment

ndkhanh-axonivy Jan 5, 2024

ndkhanh-axonivy left a comment

ndkhanh-axonivy Jan 5, 2024

ny-huynh Jan 5, 2024

ndkhanh-axonivy Jan 5, 2024

ny-huynh Jan 8, 2024

ndkhanh-axonivy left a comment

ndkhanh-axonivy Jan 8, 2024

ndkhanh-axonivy Jan 8, 2024

ndkhanh-axonivy Jan 8, 2024

ndkhanh-axonivy Jan 8, 2024

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

ndkhanh-axonivy commented Jan 10, 2024

Onboard UPS Connector to Axon-ivy market #1

Onboard UPS Connector to Axon-ivy market #1

Conversation

ndkhanh-axonivy commented Jan 3, 2024

ndkhanh-axonivy commented Jan 3, 2024

ndkhanh-axonivy commented Jan 4, 2024

ndkhanh-axonivy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndkhanh-axonivy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndkhanh-axonivy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nqhoan-axonivy Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

nqhoan-axonivy Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

nqhoan-axonivy Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

nqhoan-axonivy Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

ndkhanh-axonivy commented Jan 10, 2024

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading

nqhoan-axonivy Jan 9, 2024 •

edited

Loading