Refactor codebase for modern practices #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `Gruntfile.js` to use `const` for declaring the `sass` variable. - Renamed and simplified methods in `Constants.cs` for clarity and efficiency. - Removed unnecessary `using` directives and renamed methods in `Location.Parser.cs` for better readability. - Corrected logical operators in `StringHelper.cs` and `ColorMath.cs` to ensure proper short-circuit evaluation. - Changed nullable boolean properties to non-nullable in `EditModel.cs`. - Converted `CalendarDisplayModel` property to a method in `NewsletterModel.cs`. - Improved variable checks and declarations in JavaScript files for robustness and modern standards. - Applied similar updates to `Site.TempusDominusFactory.min.js` for consistency. - Updated `Show.cshtml` to reflect changes in `NewsletterModel.cs`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gruntfile.jsto useconstfor declaring thesassvariable.Constants.csfor clarity and efficiency.usingdirectives and renamed methods inLocation.Parser.csfor better readability.StringHelper.csandColorMath.csto ensure proper short-circuit evaluation.EditModel.cs.CalendarDisplayModelproperty to a method inNewsletterModel.cs.Site.TempusDominusFactory.min.jsfor consistency.Show.cshtmlto reflect changes inNewsletterModel.cs.