Lsm cgroup api #1135
Lsm cgroup api #1135
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please avoid opening a new PR each time. There are comments I left in #1131 that remain unaddressed. |
altugbozkurt07
force-pushed
the
lsm_cgroup_api
branch
from
92a61ab to
6a0721a
Compare
|
@tamird sorry, since we have changed the way we implemented api, i thought it deserved a new pr. For the comments that remain unaddressed; Am i missing something other than what is stated in your comments? |
altugbozkurt07
force-pushed
the
lsm_cgroup_api
branch
from
6a0721a to
91ff050
Compare
| @@ -28,6 +28,7 @@ test-case = { workspace = true } | |||
| test-log = { workspace = true, features = ["log"] } | |||
| tokio = { workspace = true, features = ["macros", "rt-multi-thread", "time"] } | |||
| xdpilone = { workspace = true } | |||
| nix = { workspace = true, features = ["process"] } | |||
There was a problem hiding this comment.
You would add any other features that were required from nix here.
I assume you needed something from the default featureset given the change in the main Cargo.toml.
aya/src/programs/lsm_cgroup.rs
Outdated
| /// The minimum kernel version required to use this feature is 6.0. | ||
| /// | ||
| /// # Examples | ||
| /// ## LSM with cgroup attachment type |
There was a problem hiding this comment.
if i remove this subheading, should i also remove it from lsm.rs ?
| let prog_fd = self.fd()?; | ||
| let prog_fd = prog_fd.as_fd(); | ||
| let cgroup_fd = cgroup.as_fd(); | ||
| let attach_type = self.data.expected_attach_type.unwrap(); |
There was a problem hiding this comment.
| let attach_type = self.data.expected_attach_type.unwrap(); | |
| let attach_type = Some(BPF_LSM_CGROUP); |
|
Please let us know when the tests are passing, or if you need help understanding the failures. |
altugbozkurt07
force-pushed
the
lsm_cgroup_api
branch
from
91ff050 to
f2493ab
Compare
|
@dave-tucker thanks for your detailed feedback, i have updated the commit accordingly. Let me know if things are good to go for this one. |
altugbozkurt07
force-pushed
the
lsm_cgroup_api
branch
from
f2493ab to
97a52dd
Compare
altugbozkurt07
force-pushed
the
lsm_cgroup_api
branch
from
97a52dd to
f67626f
Compare
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
Hi @vadorovsky, @dave-tucker,
This is the refactored work based on the discussion we have had on discord.
Let me know if i missed anything.
Best
This change is