-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aya): Add is_program_type_supported #1145
Conversation
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
This adds a new API to test whether a given program type is supported. This is to support 3 usecases: 1. A project like bpfman (which uses Aya) may wish to prevent users with a list of program types that are supported on the target system 2. A user of Aya may wish to test whether Fentry/Fexit programs are supported and code their own behaviour to fallback to Kprobes 3. Our own integration tests can be made to skip certain program tests when kernel features are missing. Signed-off-by: Dave Tucker <[email protected]>
27a6761
to
7af8bf8
Compare
Hi! I was wondering if #1063 could address the first usecase. I haven't updated it in a while, however last time I checked, program type and map type feature probing should be working correctly. I had planned to including another api for If it fits your first usecase, I can try to get my PR updated as soon as I can. :) |
Here's the thing. This was just a quick hack to unblock #1135 and I totally forgot about your PR @tyrone-wu - sorry.
|
Srry for the delay. 😖
That commit is now separated into #1162.
Just finished up some final testing for the remaining work, which should be updated in #1063. 👍 |
Thanks so much @tyrone-wu! |
This adds a new API to test whether a given program type is supported.
This is to support 3 usecases:
This change is