[TASK] Add TYPO3 v13 support

ayacoo · May 30, 2024 · 63681ca · 63681ca
1 parent d4afb4b
commit 63681ca
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 41 deletions.
diff --git a/Tests/Unit/Helper/TiktokHelperTest.php b/Tests/Unit/Helper/TiktokHelperTest.php
@@ -5,6 +5,7 @@
 namespace Ayacoo\Tiktok\Tests\Unit\Helper;
 
 use Ayacoo\Tiktok\Helper\TiktokHelper;
+use PHPUnit\Framework\Attributes\Test;
 use TYPO3\CMS\Core\Resource\File;
 use TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\AbstractOEmbedHelper;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
@@ -22,17 +23,12 @@ protected function setUp(): void
         $this->subject = new TiktokHelper('tiktok');
     }
 
-    /**
-     * @test
-     */
-    public function isAbstractOEmbedHelper(): void
+    public function testIisAbstractOEmbedHelper(): void
     {
         self::assertInstanceOf(AbstractOEmbedHelper::class, $this->subject);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function getOEmbedUrlReturnsUrl()
     {
         $mediaId = '123456';
@@ -45,9 +41,7 @@ public function getOEmbedUrlReturnsUrl()
         self::assertEquals($expectedUrl, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function getPublicUrlReturnsPublicUrl()
     {
         $properties = ['tiktok_username' => 'username123'];
@@ -70,9 +64,7 @@ public function getPublicUrlReturnsPublicUrl()
         self::assertEquals($expectedUrl, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function getMetaData()
     {
         $fileMock = $this->getMockBuilder(File::class)
@@ -112,9 +104,7 @@ public function getMetaData()
         self::assertEquals($expectedMetaData, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function handleTiktokTitle()
     {
         $title = 'Test <span>Title</span>';
@@ -127,9 +117,7 @@ public function handleTiktokTitle()
         self::assertEquals($expectedTitle, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function handleTiktokTitleWithEmojis()
     {
         $title = 'Test <span>Title 😊</span>';

diff --git a/Tests/Unit/Rendering/TiktokRendererTest.php b/Tests/Unit/Rendering/TiktokRendererTest.php
@@ -7,6 +7,8 @@
 use Ayacoo\Tiktok\Event\ModifyTiktokOutputEvent;
 use Ayacoo\Tiktok\Helper\TiktokHelper;
 use Ayacoo\Tiktok\Rendering\TiktokRenderer;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use Psr\EventDispatcher\EventDispatcherInterface;
 use TYPO3\CMS\Core\Resource\File;
 use TYPO3\CMS\Core\Resource\Rendering\FileRendererInterface;
@@ -34,17 +36,13 @@ protected function setUp(): void
         $this->subject = new TiktokRenderer($eventDispatcherMock, $configurationManagerMock);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function hasFileRendererInterface(): void
     {
         self::assertInstanceOf(FileRendererInterface::class, $this->subject);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function canRenderWithMatchingMimeTypeReturnsTrue(): void
     {
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['fal']['onlineMediaHelpers']['tiktok'] = TiktokHelper::class;
@@ -57,9 +55,7 @@ public function canRenderWithMatchingMimeTypeReturnsTrue(): void
         self::assertTrue($result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function canRenderWithMatchingMimeTypeReturnsFalse(): void
     {
         $fileResourceMock = $this->createMock(File::class);
@@ -70,10 +66,8 @@ public function canRenderWithMatchingMimeTypeReturnsFalse(): void
         self::assertFalse($result);
     }
 
-    /**
-     * @test
-     * @dataProvider getPrivacySettingWithExistingConfigReturnsBooleanDataProvider
-     */
+    #[Test]
+    #[DataProvider('getPrivacySettingWithExistingConfigReturnsBooleanDataProvider')]
     public function getPrivacySettingWithExistingConfigReturnsBoolean(array $pluginConfig, bool $expected)
     {
         $eventDispatcherMock = $this->getMockBuilder(EventDispatcherInterface::class)->getMock();
@@ -132,9 +126,7 @@ public static function getPrivacySettingWithExistingConfigReturnsBooleanDataProv
         ];
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function renderReturnsTiktokHtml(): void
     {
         $iframe = '<iframe src="https://www.tiktok.com" />';
@@ -162,9 +154,7 @@ public function renderReturnsTiktokHtml(): void
         self::assertSame($expected, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function renderWithPrivacyTrueReturnsModifiedTiktokHtml(): void
     {
         $iframe = '<iframe src="https://www.tiktok.com" />';

diff --git a/ext_localconf.php b/ext_localconf.php
@@ -16,7 +16,4 @@
 
     $GLOBALS['TYPO3_CONF_VARS']['SYS']['FileInfo']['fileExtensionToMimeType'][$mediaFileExt] = 'video/' . $mediaFileExt;
     $GLOBALS['TYPO3_CONF_VARS']['SYS']['mediafile_ext'] .= ',' . $mediaFileExt;
-
-    $iconRegistry = GeneralUtility::makeInstance(IconRegistry::class);
-    $iconRegistry->registerFileExtension('tiktok', 'mimetypes-media-image-' . $mediaFileExt);
 })('tiktok');