Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate local analysis upload matches neighborhood location #703

Open
KlaasH opened this issue Feb 6, 2019 · 0 comments
Open

Validate local analysis upload matches neighborhood location #703

KlaasH opened this issue Feb 6, 2019 · 0 comments

Comments

@KlaasH
Copy link
Contributor

KlaasH commented Feb 6, 2019

We currently validate that all the right files are there, but we're not checking that the information in the upload actually corresponds to the neighborhood it's being uploaded for.

I think it should be feasible to check while importing the results geometries that they intersect with the geometry stored on the neighborhood (e.g. intersect import_layer_map.layer.extent and job.neighborhood.geom_simple after loading the layer.

It would make sense for the validation check to be optional, since we don't need it when importing geometries during normal analysis runs. We could also do it for only one of the imports (ways or census_blocks but not both) to slowing the import down for no additional benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants