feat(Core/Config): Naxxramas - Ability to change Sapphiron encounter requirement

[avarishd]

Changes Proposed:

• Add worldserver config that enables/disables Sapphiron's requirement of having to defeat all end quater bosses in order to start the encounter (disabled by default, as per patch 3.3.0)

Issues Addressed:

• Improve on fix(Scripts/Naxxramas): Remove Sapphiron encounter boss requirements #15048

SOURCE:

Tests Performed:

• tested in-game

How to Test the Changes:

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Objection - changes of this nature should go to a module as the source files should strictly contain 3.3.5 code. There's the mod-progression-system for this purpose.

[avarishd]

I have nothing against the progression mod, but the file does contain 3.3.5 code, with the simple addition of having the ability to be changed to previous state (when/if needed) with a simple line. Icecrown buffs config are in the same basket.

[Nyeriah]

It is a progression change and we do not intend to emulate every progression change in our script files, as such, this should not be merged.

Further discussion can be found here on how to implement this using the progression module: azerothcore/mod-progression-system#308 (comment)

It's cumbersome but we can always work towards an easier and better way to achieve those changes, without, however, bloating the core script files with progression changes (like MaNGOS has done over the years)

[avarishd]

Fair enough.

[55Honey]

Still thanks for trying to help. It's the thought which counts 👍