feat(Core/Scripting): Add new hooks for Ticket #21238
Open
+143
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
sudlud
reviewed
Feb 4, 2025
sudlud
reviewed
Feb 6, 2025
| CALL_ENABLED_HOOKS(TicketScript, TICKETHOOK_ON_TICKET_RESOLVE, script->OnTicketResolve(player, ticket)); | ||
| } | ||
|
|
||
| TicketScript::TicketScript(const char* name, std::vector<uint16> enabledHooks) |
There was a problem hiding this comment.
I don't understand why you want to change this, when it has no impact, is it by convention?
There was a problem hiding this comment.
| class TicketScript : public ScriptObject | ||
| { | ||
| protected: | ||
| TicketScript(const char* name, std::vector<uint16> enabledHooks = std::vector<uint16>()); |
| { | ||
| _lastChange = GameTime::GetGameTime().count(); | ||
|
|
||
| sScriptMgr->OnTicketUpdate(ticket->GetPlayer(), ticket); |
There was a problem hiding this comment.
probably better named as OnTicketUpdateLastChange ?
| #include "ScriptMgr.h" | ||
| #include "ScriptMgrMacros.h" | ||
|
|
||
| void ScriptMgr::OnTicketCreate(Player* player, GmTicket* ticket) |
There was a problem hiding this comment.
i must say that I don't see a benefit of adding the player parameter here. you can always get it from the ticket, right? by adding this parameter, you're also adding a call to ticket->GetPlayer() for each hook call even if the hooks are unused
There was a problem hiding this comment.
Yes, that's right, you can access the player directly from GMTicket, I've added ‘player’ out of habit x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.