Added new hooks for repuation gaining to the player #21306
+213
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
Kitzunu
requested changes
Feb 3, 2025
There was a problem hiding this comment.
there is no reason to create a new file for this. Keep it in Player.h
There was a problem hiding this comment.
changelog is an outdaterd - not used system. You can remove them
Tondorian
force-pushed
the
feature/OnPlayerReputationChangeExtension
branch
from
59fefdf to
84a8f3c
Compare
Kitzunu
reviewed
Feb 5, 2025
added default case to switch Co-authored-by: Kitzunu <[email protected]>
Kitzunu
reviewed
Feb 5, 2025
| /** | ||
| * @brief This enum represent all known sources a character can get reputation | ||
| */ | ||
| enum class ReputationSource : uint8 { |
There was a problem hiding this comment.
Suggested change
| enum class ReputationSource : uint8 { | |
| enum class ReputationSource : uint8 | |
| { |
Kitzunu
reviewed
Feb 5, 2025
| @@ -114,7 +115,9 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player* player, uint32 trigger) | |||
| // add 19 honor | |||
| player->RewardHonor(nullptr, 1, 19); | |||
| // add 20 cenarion circle repu | |||
| player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20.f); | |||
| float reputation = 20.f; | |||
| ScriptMgr::instance()->OnBeforePlayerReputationChange(player, 609, reputation, ReputationSource::PvP); | |||
|
Is there any way for this to be condensed? So it's not called in 20 different places in the core? |
|
Maybe in ReputationMgr, but this will require to rework most functions, as they don't know about quests and units. And in my opinion ReputationMgr should not know about this information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.