fix(Core): Fix After PR#21213 Crash

[PkllonG]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes
• instant dungeon error #21326
• Crash when entering raid instance in single-player mode. #21323
• Feature: Fix for Segmentation Fault in AzerothCore while SendingAreaTriggerMessages #21324

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[PkllonG]

Please Test adam8014 54thC saligin

[PkllonG]

After PR, in my case, the server no longer crashes

[TheSCREWEDSoftware]

Tested and no longer crashes the worldserver. I don't know what's failing on the linux build

[Kitzunu]

this should be kept string.

[Kitzunu]

rest looks good

[PkllonG]

That's where the server crashes
std::string crash

[Kitzunu]

It wont after the changes you made on the other places. Since they are now taken

void SendAreaTriggerMessage(uint32 strId, Args&&... args)

And if std::string is the issue we should fix that, not revert back to char

[PkllonG]

[PkllonG]

Most of the time the compiler will think: std::string == std::string_view
This creates an endless loop, and then the server crashes

[54thC]

Please Test adam8014 54thC saligin

After testing, it operates smoothly without resulting in a core crash.

[adam8014]

adam8014 54thC saligin을 테스트해 보세요.

After applying the fix(Core), the problem no longer occurs. It has been resolved. Thank you. :)

[saligin]

Пожалуйста, проверьте adam8014 54thC салигин
Everything works, I checked it on Ubuntu 22.04 Jammy.