Add GetReactState to CreatureMethods and GetKnownTaxiNodes, SetKnownTaxiNodes to PlayerMethods #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added GetKnownTaxiNodes and SetKnownTaxiNodes to PlayerMethods. All 3 functions have been tested by me and are currently in use in a couple of scripts utilizing Eluna. |
Aldori15
changed the title
55Honey
requested changes
Feb 17, 2025
src/LuaEngine/LuaFunctions.cpp
Outdated
| @@ -556,6 +556,8 @@ ElunaRegister<Player> PlayerMethods[] = | |||
| { "SetLifetimeKills", &LuaPlayer::SetLifetimeKills }, | |||
| { "SetGameMaster", &LuaPlayer::SetGameMaster }, | |||
| { "SetGMChat", &LuaPlayer::SetGMChat }, | |||
| { "GetKnownTaxiNodes", &LuaPlayer::GetKnownTaxiNodes }, | |||
There was a problem hiding this comment.
Please keep getters in their own section.
Same for GetReactState
There was a problem hiding this comment.
Please keep getters in their own section. Same for GetReactState
Fixed. Thanks for the response :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the ability to SetReactState, but we don't have to ability to GetReactState.