Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple workspace, profile, and flow params #63

Merged
merged 14 commits into from
Dec 26, 2022

Conversation

azriel91
Copy link
Owner

Closes #45.
Needed for #35.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 89.82% // Head: 91.01% // Increases project coverage by +1.19% 🎉

Coverage data is based on head (c3a1f90) compared to base (ad8c6d2).
Patch coverage: 98.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   89.82%   91.01%   +1.19%     
==========================================
  Files         158      166       +8     
  Lines        9147     9730     +583     
==========================================
+ Hits         8216     8856     +640     
+ Misses        931      874      -57     
Impacted Files Coverage Δ
crate/resources/src/internal/flow_params_file.rs 100.00% <ø> (ø)
...rate/resources/src/internal/profile_params_file.rs 100.00% <ø> (ø)
...te/resources/src/internal/workspace_params_file.rs 100.00% <ø> (ø)
crate/rt_model_native/src/error.rs 50.00% <ø> (ø)
workspace_tests/src/resources/states.rs 95.55% <ø> (ø)
...t_model_core/src/cmd_context_params/flow_params.rs 86.36% <86.36%> (ø)
...odel_core/src/cmd_context_params/profile_params.rs 86.36% <86.36%> (ø)
...el_core/src/cmd_context_params/workspace_params.rs 86.36% <86.36%> (ø)
crate/rt_model_native/src/native_storage.rs 67.60% <96.15%> (-9.52%) ⬇️
...orkspace_tests/src/rt_model/states_deserializer.rs 98.70% <98.70%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the feature/45/multiple-init-params-support branch from 396ce23 to 3f7f17d Compare December 26, 2022 06:12
@azriel91 azriel91 force-pushed the feature/45/multiple-init-params-support branch from dae476b to c3a1f90 Compare December 26, 2022 23:01
@azriel91 azriel91 merged commit a89e26d into main Dec 26, 2022
@azriel91 azriel91 deleted the feature/45/multiple-init-params-support branch December 26, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Init Params Support
1 participant