Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Update Highlight.php #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Highlight.php #185

wants to merge 1 commit into from

Conversation

Surt
Copy link

@Surt Surt commented Feb 4, 2019

@iget-esoares
Copy link
Collaborator

Hi @Surt,

Could you please describe your changes and reasons?

Also would be greate to have tests for your changes.

@Surt
Copy link
Author

Surt commented Mar 25, 2019

Hi @iget-esoares it was just a quick proposal. It adds \ArrayAccess, \Iterator to the Highlight results object. Now it is possible to transverse throught the hightlighted results with a foreach. As well as accesing the results as it was an Array.

I'm not having the necesary time right now. I will try to make an adecuate pull request someday if nobody take it from here.

By the way, looking again i see it could be done easily just setting $highlight property as public ....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants