-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Compatibility issues (fix Pipeline) #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y flag from Makefile
…struct definition in Boost
…ify hash_base struct definition in Boost
…Python components in find_package; update pybind11 version in environment.yml
…remove unused C++ standard setting in CMakeLists.txt
…irectory handling
…nclude directory handling" This reverts commit e40625d.
…cific compile definitions
…er in pairsnp.hpp
Remove wchar.h include from wtsne.hpp to clean up unused dependencies
…gs; add debug output in normalise_vector function
…X_FLAGS for optimization
… cwchar in python_bindings.cpp for improved compatibility and standard compliance
…hon_bindings.cpp and wtsne.hpp
…t directories for improved compatibility
… to include boost-cpp dependency
…roved code clarity
…a values and optimize loop indexing; add debug output for P values
… and remove debug output for P values
… Python build matrix
…variables with simpler types and optimizing OpenMP scheduling
johnlees
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this mammoth effort!! All these changes make sense
Sorry about the openmp pyerrcheck one – I'd found that and fixed it in pp-sketchlib after some pain but had forgotten the same was being done here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version 1.2.3 deployed falls over when running on Python >=v3.12 and The CXX compiler GNU) version >=13. Thus the following fixes have been made to ensure it works across these permutations of dependencies. These are both used by conda-forge in the feedstock and therefore should fix current feedstock pipeline woes.
Python >3.12 issues
sce.py
line 34,pd.Series.to_csv
usessep='\n'
which is no longer valid, and thus is removed as this is already the default for the seriespairsnp.hpp
when checking PyErr_CheckSignals() inside of openmp loop. To fix, Had to ensure this is only checked from the main thread.GNU 13 issues
conditional_probabilities
func inwtsne.hpp
was returning 0s and nans causing failure later in "RuntimeError: Probability vector has negative entries" in line 22 ofvector_norm.hpp
. The reason was becausestd::numeric_limits<real_t>::infinity()
was used forbeta_min
andbeta_max
. This infinity causes issues with different compiler versions and thus have changed to usestd::numeric_limits<real_t>::max()
.Also small type mismatch int & size_t in
kseq.h1
that raised warnings. Thus have typecasted to fix.Note: ubuntu-22.04 uses GNU 11 and ubuntu-latest uses GNU-13. Thus have added as matrix in pipeline