Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated timestamp_nanos_opt method #22

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Replace deprecated timestamp_nanos_opt method #22

merged 4 commits into from
Oct 8, 2024

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Mar 31, 2024

Replaces deprecated timestamp_nanos with timestamp_nanos_opt

bahlo
bahlo requested changes Oct 8, 2024
View reviewed changes
Copy link
Owner

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the unwrap in there. Need to figure out how to propagate or ignore that error.

@bahlo
Copy link
Owner

bahlo commented Oct 8, 2024

I think propagating the error up and returning in next_id is the best way to go.

@bahlo bahlo enabled auto-merge October 8, 2024 16:26
@bahlo bahlo merged commit 7547d61 into bahlo:main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahlo bahlo bahlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@negezor @bahlo