Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: add group prop #95

Merged
merged 7 commits into from
Jun 19, 2019
Merged

[feat]: add group prop #95

merged 7 commits into from
Jun 19, 2019

Conversation

logaretm
Copy link
Contributor

@logaretm logaretm commented Jun 18, 2019

This PR implements the group prop using an event bus instead of component references.

Checklist

  • Implement group prop.
  • Update docs.

Overview

Carousels can now be synced no matter how deeply nested inside other components, it also supports binding the group prop to get dynamic groups working.

This PR addresses the goals in #94 :

  • Ability to sync more than two carousels.
  • Syncing carousels will be context independent.
  • Fix issue when passing carousel to another component slot.

Example usage:

<hoooper group="myCarousel">
    ...
</hooper>

<hoooper group="myCarousel">
    ...
</hooper>

<hoooper group="myCarousel">
    ...
</hooper>

PS: This PR removes some unused dependencies due to Vuepress 1.x upgrade.

Issues affected

closes #94
closes #69
closes #55

@logaretm logaretm requested a review from ismail9k June 18, 2019 09:31
@ismail9k
Copy link
Contributor

ismail9k commented Jun 18, 2019

It looks like you are using a different lint setup⁠ (using double quotes, and space after function declaration⁠, ...). So please include your lint setting file, to have a consistent style all over the project.

@logaretm
Copy link
Contributor Author

@abdelrahman3d I have updated the linting config as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants