Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs to 21.5.0 #337

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Update nodejs to 21.5.0 #337

merged 1 commit into from
Dec 20, 2023

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Dec 19, 2023

Change-type: major

@joshbwlng
Copy link

@Page- Node 21.5.0 is out now if you want to go ahead and bump to that? https://github.com/nodejs/node/releases

@thgreasi thgreasi disabled auto-merge December 20, 2023 08:13
@thgreasi
Copy link
Contributor

I'm fine with it but I'm curious how you changed your mind about non-LTS releases 🤔
Was it the ESM improvements? Was it the WebStreams & WebSockets?

@thgreasi
Copy link
Contributor

thgreasi commented Dec 20, 2023

I mean, the nodejs website even says:

Production applications should only use Active LTS or Maintenance LTS releases.

See: https://nodejs.org/en/about/previous-releases

Change-type: major
@Page-
Copy link
Contributor Author

Page- commented Dec 20, 2023

@thgreasi you were in the call where we discussed this and decided it makes sense for us. But basically with how heavily we use nodejs it will be beneficial to find any issues updating sooner and also be able to make use of new functionality, vs it being more of a side thing where we aren't constantly interacting with it and would rather batch updates

@Page- Page- changed the title Update nodejs to 21.4.0 Update nodejs to 21.5.0 Dec 20, 2023
@Page- Page- enabled auto-merge December 20, 2023 11:57
@Page- Page- merged commit 521c781 into master Dec 20, 2023
@Page- Page- deleted the nodejs-21 branch December 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants