gggg

.github/actions/publish/action.yml

@@ -29,7 +29,7 @@ runs:
 
     - name: Extract custom source artifact
       if: runner.os != 'Windows'
-      shell: pwsh
+      shell: bash
       working-directory: .
       run: tar -xf ${{ runner.temp }}/custom.tgz
 
@@ -47,11 +47,8 @@ runs:
 
     - name: Install host dependencies
       if: runner.os == 'Linux'
-      shell: bash --noprofile --norc -eo pipefail -x {0}
-      run: |
-        set -ea
-        sudo apt-get update
-        sudo apt-get install -y --no-install-recommends fakeroot dpkg rpm
+      shell: bash
+      run: sudo apt-get install -y --no-install-recommends fakeroot dpkg rpm
 
     - name: Install host dependencies
       if: runner.os == 'macOS'
@@ -66,7 +63,7 @@ runs:
     # https://dev.to/rwwagner90/signing-electron-apps-with-github-actions-4cof
     - name: Import Apple code signing certificate
       if: runner.os == 'macOS'
-      shell: bash --noprofile --norc -eo pipefail -x {0}
+      shell: bash
       run: |
         KEY_CHAIN=build.keychain
         CERTIFICATE_P12=certificate.p12
@@ -102,37 +99,40 @@ runs:
         encodedString: ${{ fromJSON(inputs.secrets).WINDOWS_SIGNING }}
 
     - name: Package release
-      id: package_release
-      shell: bash --noprofile --norc -eo pipefail -x {0}
+      shell: bash
+      # IMPORTANT: before making changes to this step please consult @engineering in balena's chat.
       run: |
-        set -ea
-
-        [[ '${{ inputs.VERBOSE }}' =~ on|On|Yes|yes|true|True ]] && set -x
-
-        runner_os="$(echo "${RUNNER_OS}" | tr '[:upper:]' '[:lower:]')"
+        if [[ '${{ inputs.VERBOSE }}' =~ on|On|Yes|yes|true|True ]]; then
+          export DEBUG='electron-forge:*,electron-packager,electron-rebuild'
+        fi
 
         APPLICATION_VERSION="$(jq -r '.version' package.json)"
 
-        if [[ $runner_os =~ linux ]]; then
+        if [[ "${RUNNER_OS}" == Linux ]]; then
           BUILD_ARCH=x64
-          npm run make -- --arch="${BUILD_ARCH}"
+          SHA256SUM_BIN=sha256sum
 
-        elif [[ $runner_os =~ darwin|macos|osx ]]; then
+        elif [[ "${RUNNER_OS}" == Darwin ]]; then
           BUILD_ARCH=x64,arm64
-          npm run make -- --arch="${BUILD_ARCH}"
+          SHA256SUM_BIN='shasum -a 256'
 
-        elif [[ $runner_os =~ windows|win ]]; then
+        elif [[ "${RUNNER_OS}" == Windows ]]; then
           BUILD_ARCH=ia32,x64
-          npm run make-debug-win -- --arch="${BUILD_ARCH}"
 
         else
-          echo "ERROR: unexpected runner OS: ${runner_os}"
+          echo "ERROR: unexpected runner OS: ${RUNNER_OS}"
           exit 1
         fi
 
+        # npm link ts-node '@electron-forge/[email protected]'
+        ./node_modules/.bin/electron-forge make --arch="${BUILD_ARCH}"
+
         echo "version=${APPLICATION_VERSION}" >> $GITHUB_OUTPUT
 
         # collect all artifacts from subdirectories under a common top-level directory
+        if [[ -d dist ]]; then
+          rm -rf dist/
+        fi
         mkdir -p dist
         find ./out/make -type f \( \
           -iname "*.zip" -o        \
@@ -143,6 +143,11 @@ runs:
           -iname "*Setup.exe"      \
         \) -ls -exec cp '{}' dist/ \;
 
+        if [[ -n "${SHA256SUM_BIN}" ]]; then
+          # Compute and save digests.
+          cd dist/
+          ${SHA256SUM_BIN} *.* >"SHA256SUMS.${RUNNER_OS}.txt"
+        fi
       env:
         # ensure we sign the artifacts
         NODE_ENV: production

.github/actions/test/action.yml

@@ -30,10 +30,8 @@ runs:
 
     - name: Install host dependencies
       if: runner.os == 'Linux'
-      shell: bash --noprofile --norc -eo pipefail -x {0}
+      shell: bash
       run: |
-        set -ea
-        sudo apt-get update
         sudo apt-get install -y --no-install-recommends xvfb libudev-dev
         cat < package.json | jq -r '.hostDependencies[][]' - | \
           xargs -L1 echo | sed 's/|//g' | xargs -L1 \
@@ -48,21 +46,20 @@ runs:
       with:
         python-version: '3.11'
 
+    - name: Install project dependencies
+      shell: bash
+      run: npm ci
+
     - name: Test release
-      shell: bash --noprofile --norc -eo pipefail -x {0}
-      run: |
-        set -ea
-        runner_os="$(echo "${RUNNER_OS}" | tr '[:upper:]' '[:lower:]')"
-        npm ci
-        npm run package
-        npm run test-${runner_os}
+      shell: bash
+      run: ./build/test-all.sh
       env:
         # https://www.electronjs.org/docs/latest/api/environment-variables
         ELECTRON_NO_ATTACH_CONSOLE: 'true'
 
     - name: Compress custom source
       if: runner.os != 'Windows'
-      shell: pwsh
+      shell: bash
       run: tar -acf ${{ runner.temp }}/custom.tgz .
 
     - name: Compress custom source

.gitignore

@@ -96,6 +96,9 @@ out/
 
 # ---- Do not modify entries above this line ----
 
+# Build artifacts
+dist/
+
 # Certificates
 *.spc
 *.pvk

build/test-all.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+
+set -ea
+
+if [[ "$VERBOSE" =~ 1|on|On|Yes|yes|true|True ]]; then
+  set +x
+  export DEBUG='electron-forge:*,electron-packager,electron-rebuild'
+fi
+
+npm run package
+npm run lint
+
+case "$(uname -s)" in
+  "Linux")
+    xvfb-run --auto-servernum npm run test-gui && xvfb-run --auto-servernum npm run test-shared
+    ;;
+  "Darwin")
+    npm run test-gui && npm run test-shared
+    ;;
+  "Windows"*|"MINGW"*|"MSYS"*)
+    npm run test-gui && npm run test-shared
+    ;;
+esac

forge.config.ts

@@ -7,7 +7,7 @@ import { MakerDMG } from '@electron-forge/maker-dmg';
 import { MakerAppImage } from '@reforged/maker-appimage';
 import { AutoUnpackNativesPlugin } from '@electron-forge/plugin-auto-unpack-natives';
 import { WebpackPlugin } from '@electron-forge/plugin-webpack';
-import { ResourcePlugin } from 'electron-forge-resource-plugin';
+// import { ResourcePlugin } from 'electron-forge-resource-plugin';
 
 import { mainConfig, rendererConfig } from './webpack.config';
 
@@ -134,6 +134,7 @@ const config: ForgeConfig = {
         ],
       },
     }),
+    /*
     new ResourcePlugin({
       env: 'ETCHER_UTIL_BIN_PATH',
       path: `out/sidecar/bin/etcher-util${process.platform === 'win32' ? '.exe' : ''}`,
@@ -142,6 +143,7 @@ const config: ForgeConfig = {
         sources: './lib/util/',
       },
     }),
+    */
   ],
 };