Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.9.x] Fix typecast error thrown for default record field #43540

Conversation

HindujaB
Copy link
Contributor

@HindujaB HindujaB commented Nov 1, 2024

Purpose

$subject

Fixes #43541

Approach

when populating the default values with record type, we need to handle the type-reference type as well.

Samples

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 3ed166d into ballerina-platform:2201.9.x Nov 2, 2024
5 checks passed
@warunalakshitha
Copy link
Contributor

Lets add a test case in master PR.

@tharindu-nw tharindu-nw added this to the 2201.9.5 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants