Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.10.x] Fix typecast error thrown for default record field #43544

Open
wants to merge 4 commits into
base: 2201.10.x
Choose a base branch
from

Conversation

HindujaB
Copy link
Contributor

@HindujaB HindujaB commented Nov 4, 2024

Purpose

$subject

Fixes #43541

Approach

when populating the default values with record type, we need to handle the type-reference type as well.

Samples

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link
Contributor

@ravinperera00 ravinperera00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (592dd20) to head (4ed1d62).
Report is 1 commits behind head on 2201.10.x.

Additional details and impacted files
@@               Coverage Diff               @@
##             2201.10.x   #43544      +/-   ##
===============================================
- Coverage        77.30%   77.28%   -0.02%     
+ Complexity       58531    58529       -2     
===============================================
  Files             3460     3460              
  Lines           220087   220087              
  Branches         28916    28916              
===============================================
- Hits            170133   170099      -34     
- Misses           40541    40574      +33     
- Partials          9413     9414       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants