[Master] Generate new typedesc instruction for record and tuple when type descriptor resolving

[rdulmina]

Purpose

In this PR, I have generated a new 'typedesc' (type descriptor) only once for the tuple and record.
For example:

type Foo record {||};
public function main() {
    Foo f = {};
    record {|int a;|} r = {a: 1};
}

We have desugared the above program as follows:

type Foo record {||};
typedesc<Foo> $typedesc$Foo = Foo;
public function main() {
    Foo f = {};
    typedesc<record {| int a; |}> $typedesc$$anonType$_0 = record {| int a; |}
    record {|int a;|} r = {a: 1};
}

We then use the generated 'typedesc' when creating a map value using that type.

Fixes #38844, #41946, #43311

[MaryamZi]

Why do we need this change? Are these annotations only in the typedesc, not in the type?

[rdulmina]

They are in both the places. I think we can remove this for now

[rdulmina]

Removed this

[MaryamZi]

Do we really need this? Given that we don't anticipate additions, can just call and see in order?

[rdulmina]

Yes that was the previous code. But it was lengthy. A con I feel with this approach is its hard to read and debug. I'm +1 to go with any approach. WDYT?

[MaryamZi]

What scenario is this required for atm?

[sonarcloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE