Add Ballerina metrics logs observer #43615
Open
+127
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,112 @@ | |||
| package io.ballerina.runtime.observability.metrics; | |||
There was a problem hiding this comment.
License text missing
| import java.util.Set; | ||
|
|
||
| import static io.ballerina.runtime.observability.ObservabilityConstants.*; | ||
|
|
There was a problem hiding this comment.
Shall we add java doc for class
|
|
||
| import static io.ballerina.runtime.observability.ObservabilityConstants.*; | ||
|
|
||
| public class BallerinaMetricsLogsObserver implements BallerinaObserver { |
There was a problem hiding this comment.
should this be moved to observe side
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43615 +/- ##
============================================
- Coverage 77.47% 77.45% -0.02%
Complexity 58512 58512
============================================
Files 3434 3435 +1
Lines 218711 218766 +55
Branches 28918 28920 +2
============================================
+ Hits 169443 169446 +3
- Misses 39874 39928 +54
+ Partials 9394 9392 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are implementing log based metrics for Ballerina as a requirement for all WSO2 on-prem and SaaS products that need to use the same stack for observability. In order to retrieve metrics data using OpenSearch, we need to provide log based metrics which contain a format as follows.
[Time Stamp] protocol:<protocol_type> tagKey1:tagValue1 tagKey2:tagValue2 .. response_time:<value_in_seconds>
Fixes #43614
Approach
Samples
Remarks
Check List