Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LDAPS #66

Merged
merged 21 commits into from
Oct 28, 2024
Merged

Support LDAPS #66

merged 21 commits into from
Oct 28, 2024

Conversation

DaAlbrecht
Copy link
Contributor

@DaAlbrecht DaAlbrecht commented Oct 14, 2024

Description

Provide a similar way as in the HTTP module to configure secure socket configurations.

Implements ballerina-platform/ballerina-library#7250

One line release note:

  • Support LDAPS

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Added additional Ballerina unit tests

Test Configuration:

  • Ballerina Version: Ballerina 2201.10.1 (Swan Lake Update 10)
  • Operating System: MacOS
  • Java SDK: openjdk 17.0.9

Checklist:

Security checks

ballerina/tests/test.bal Outdated Show resolved Hide resolved
@ayeshLK
Copy link
Member

ayeshLK commented Oct 23, 2024

Lets move ballerina/tests/server directory into ballerina/tests/resources.

@DaAlbrecht
Copy link
Contributor Author

Lets move ballerina/tests/server directory into ballerina/tests/resources.

Yes sorry i thought with 2201.10.0 (Swan Lake) resources are not longer supported for modules. But this does not apply to tests.

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nuvindu Nuvindu merged commit 8ed1460 into ballerina-platform:master Oct 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants