Improve error message for client configuration failures #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDPerera
requested review from
aashikam,
niveathika and
sahanHe
as code owners
RDPerera
force-pushed
the
release-8.0.2
branch
from
f8a026b
to
867a8c4
Compare
| http:ClientConfiguration httpClientConfig = check config:constructHTTPClientConfig(config); | ||
| httpClientResult = trap new (config.baseUrl, httpClientConfig); |
There was a problem hiding this comment.
Will it handle panic situations properly?
There was a problem hiding this comment.
@TharmiganK , Do we need to handle panics here ?
There was a problem hiding this comment.
This is just the HTTP client initialisation right? In error situations, we explicitly return a http:ClientError rather than panicing
RDPerera
force-pushed
the
release-8.0.2
branch
from
9611e5c
to
48a3bdf
Compare
TharmiganK
reviewed
Nov 20, 2024
|
Moved to #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: https://github.com/wso2-enterprise/internal-support-ballerina/issues/838