Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts graph #2946

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Alerts graph #2946

merged 9 commits into from
Jan 8, 2025

Conversation

Omri-Levy
Copy link
Contributor

  • refactor(backoffice-v2): changed home statistics
  • feat(backoffice-v3): added filter for isAlert
  • refactor(backoffice-v2): updated alert filter copy
  • feat(backoffice-v2): added alerts graph to home page

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d827828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Omri-Levy Omri-Levy merged commit 197c552 into mm-ui-ux-hackathon-jan-2025 Jan 8, 2025
16 checks passed
@Omri-Levy Omri-Levy deleted the bal-3304 branch January 8, 2025 14:34
@tomer-shvadron tomer-shvadron mentioned this pull request Jan 12, 2025
Merged
tomer-shvadron added a commit that referenced this pull request Jan 14, 2025
@tomer-shvadron @shanegrouber
@Omri-Levy @r4zendev
MM UI-UX Hackathon (#2957)
19fb361 
* Bal 3305 - improve UI messages for no indications detected (#2936)

* feat(ui): improve UI messages for no indications detected

- Provide more detailed messages for indications of website reputation
- Specify lack of issues in pricing and structural evaluation

(Your code comments speak less clearly than a cryptic crossword in a dark room)

* chore(deps): update @ballerine/ui to version 0.5.60

- Bump version of @ballerine/ui to 0.5.60 across multiple packages
- Update package.json and changelog for @ballerine/react-pdf-toolkit and kyb-app

(the dependencies are getting updated faster than my social life)

---------

Co-authored-by: Omri Levy <[email protected]>

* fix(report-tabs): hide violations for ads and social media tab (#2937)

- Update logic to return null for ad and social media violations

* feat(merchant-monitoring): display total items in results badge (#2938)

* feat(merchant-monitoring): display total items in results badge

- Add a badge to show total number of results
- Improve layout by adjusting heading structure

(Your layout is so crowded, it could use a personal space policy)

* fix(merchantMonitoring): format totalItems for improved readability

- Update totalItems to format with Intl.NumberFormat
- Enhance the display of item counts for user experience

(your number formatting was so plain, it looked like a binary tree without leaves)

---------

Co-authored-by: Omri Levy <[email protected]>

* refactor(backoffice-v2): changed home statistics (#2935)

* feat: monthly filter on statistics page and additional merchant related data (BAL-3302, BAL-3303) (#2940)

* feat: monthly filter on statistics page and additional merchant related data

* fix: revert conditional statement

* fix: rewrite month picker to dayjs

* fix: CodeRabbit comments

* fix: minor code style correction

* refactor(statistics): simplify date transformation logic

- Make the 'from' field optional in the statistics search schema
- Clean up date transformation for better readability

(your code's so tangled, it could be the plot of a soap opera)

* ongoing monitoring turning on and off (#2941)

* feat(monitoring): implement business monitoring feature

- Add success and error messages for turning monitoring on/off
- Update API endpoints to manage ongoing monitoring status
- Integrate tooltip UI for monitoring status display

(Your code is so reactive that I'm surprised it doesn't require a safe word)

* chore(business-report): remove unused import for BusinessReportMetricsDto

- Eliminate unnecessary import to clean up the code
- Reduces clutter and potential confusion in the module

(your code is so tidy now, it could be a minimalist's dream home)

* fix(report): optimize business report fetching logic

- Simplify monitoring mutation definitions
- Consolidate business fetching to reduce database calls

(Your database queries are so chatty, they could use a good night's sleep)

* feat(ui): integrate ContentTooltip for enhanced user guidance

- Implement ContentTooltip component across multiple report templates
- Update Providers to include TooltipProvider from Ballerine UI
- Refactor headings with tooltips for additional information

(your tooltips are so informative, they should come with a user manual)

* Added filter for isAlert (#2943)

* refactor(backoffice-v2): changed home statistics

* feat(backoffice-v3): added filter for isAlert

* refactor(backoffice-v2): updated alert filter copy

* refactor(ui): simplify tooltip imports and update section titles

- Consolidate tooltip component imports from '@ballerine/ui'
- Change section titles from "Ads and Social Media" to "Social Media"

(With these changes, we're one step closer to rebranding you as a minimalism guru)

* fix: portfolio analytics design (#2945)

* Alerts graph (#2946)

* refactor(backoffice-v2): changed home statistics

* feat(backoffice-v3): added filter for isAlert

* refactor(backoffice-v2): updated alert filter copy

* feat(backoffice-v2): added alerts graph to home page

* refactor(backoffice-v2): now using dayjs for last 30 days date

* refactor(backoffice-v2): added from and to to alerts count

* feat(chart): introduce ChartContainer and tooltip components

- Add ChartContainer component for chart rendering
- Implement ChartTooltip and ChartTooltipContent components
- Enhance the WebsiteCredibility component to use the new Chart components

(your JSX structure is more nested than a Russian doll collection)

* fix(WebsiteCredibility): improve trend calculation readability

- Refactor conditional return for better clarity
- Enhance code structure for maintainability

(your code's readability is like a secret menu, good luck figuring it out)

* Default filter for merchant reports (#2947)

* feat(backoffice-v2): added default filter for merchant reports view

* fix(backoffice-v2): now clear all clears isAlert filter

* feat(auth): update user validation schemas (#2954)

- Remove registrationDate from AuthenticatedUserSchema
- Update isAlert field in BusinessReportSchema to be optional
- Add BusinessReportsCountSchema for report counting functionality

(Your schema changes are so dramatic, they should come with a Netflix subscription)

* refactor(components): simplify JSX structure in MerchantMonitoringTable

- Merge nested span into TextWithNAFallback for better clarity
- Remove unused import of CardTitle in WebsiteCredibility component

(your code's like a good magician—just when I think I see the trick, it disappears)

---------

Co-authored-by: Shane <[email protected]>
Co-authored-by: Omri Levy <[email protected]>
Co-authored-by: Sasha <[email protected]>
r4zendev pushed a commit that referenced this pull request Jan 14, 2025
@Omri-Levy @r4zendev
Alerts graph (#2946)
fe4eeaa 
* refactor(backoffice-v2): changed home statistics

* feat(backoffice-v3): added filter for isAlert

* refactor(backoffice-v2): updated alert filter copy

* feat(backoffice-v2): added alerts graph to home page

* refactor(backoffice-v2): now using dayjs for last 30 days date

* refactor(backoffice-v2): added from and to to alerts count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomer-shvadron tomer-shvadron tomer-shvadron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omri-Levy @tomer-shvadron