Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLP-12627: balHighlight not highlighting parts of href #64

Merged
merged 3 commits into from
Jan 15, 2024
Merged

NLP-12627: balHighlight not highlighting parts of href #64

merged 3 commits into from
Jan 15, 2024

Conversation

PredragMPetrovic
Copy link
Collaborator

@PredragMPetrovic PredragMPetrovic commented Jan 11, 2024 •
edited
Loading

We have following issue:

  • we get html message from the BE, and then we do balHighlight on that
  • if you search for part of the href (for example name of the document), then url will get messed up and not work anymore (since span is injected in href)

This solution should solve that issue.

Issue in Jira:
https://jira.baloisenet.com/browse/NLP-12627

@yannickholzenkamp
Copy link
Member

Hey @PredragMPetrovic, could you adjust the test for the pipe as well?

@PredragMPetrovic
Copy link
Collaborator Author

Hey @PredragMPetrovic, could you adjust the test for the pipe as well?

Sure, just added test :)

@PredragMPetrovic PredragMPetrovic merged commit fc35f84 into master Jan 15, 2024
1 check passed
@PredragMPetrovic PredragMPetrovic mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predrag-arsic predrag-arsic predrag-arsic approved these changes

@yannickholzenkamp yannickholzenkamp yannickholzenkamp approved these changes

@NoraKurzbein NoraKurzbein Awaiting requested review from NoraKurzbein

@hirsch88 hirsch88 Awaiting requested review from hirsch88 hirsch88 is a code owner

@nobilo nobilo Awaiting requested review from nobilo nobilo is a code owner

@lazaki lazaki Awaiting requested review from lazaki lazaki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PredragMPetrovic @yannickholzenkamp @predrag-arsic