Stop accidentally relying on untyped objects #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bannable
force-pushed
the
resolve-untyped-class
branch
from
de22620 to
9a0ea10
Compare
bannable
force-pushed
the
resolve-untyped-class
branch
from
9a0ea10 to
4e9e492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From sorbet/sorbet#7038, the return type from
self.classin a module that usesmixes_in_class_methodsis untyped.To get better type coverage, I am removing most uses of
self.classin the library. This also allows me to stop relying oninclude Kernelin the variousInterfaces, and to start treating the protocol objects as proper singletons.These changes do not affect any public APIs, so there is no version change.
Resolves #69