Fix page title length check when it has html #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshmarov
changed the title
| @@ -44,8 +46,8 @@ def header_arguments | |||
| tag: "div", | |||
| classes: class_names( | |||
| "Polaris-Page-Header--mobileView", | |||
| "Polaris-Page-Header--mediumTitle": @title.present? && @title.length <= LONG_TITLE, | |||
| "Polaris-Page-Header--longTitle": @title.present? && @title.length > LONG_TITLE, | |||
| "Polaris-Page-Header--mediumTitle": @title.present? && (@force_medium_title || @title.length <= LONG_TITLE), | |||
There was a problem hiding this comment.
@yshmarov Maybe stripping HTML from @title before checking length will be easier?
https://api.rubyonrails.org/classes/ActionView/Helpers/SanitizeHelper.html#method-i-strip_tags
There was a problem hiding this comment.
this is indeed much better. I've updated
There was a problem hiding this comment.
Looks good! 👍 Please check tests and we can merge it
kirillplatonov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectation:
reality:
this is because the inline title length can be max 34 characters.
but I am using some html around the actual text, so I have more characters.
this way I can ensure that title is inline