Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close modal when clicking outside #435

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

remy727
Copy link
Contributor

@remy727 remy727 commented Jul 26, 2024

WHAT is this pull request doing?

Close modal when clicking outside

@remy727 remy727 changed the title WIP: Close modal when clicking outside Close modal when clicking outside Jul 27, 2024
@remy727
Copy link
Contributor Author

remy727 commented Jul 27, 2024

@kirillplatonov, this PR is ready for review.

@remy727
Copy link
Contributor Author

remy727 commented Jul 30, 2024

@kirillplatonov, can you please review this one when you have a chance?

Copy link
Collaborator

@kirillplatonov kirillplatonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@kirillplatonov kirillplatonov merged commit 4ecbb10 into baoagency:main Jul 30, 2024
4 checks passed
@remy727
Copy link
Contributor Author

remy727 commented Jul 30, 2024

Thank you 👍

@remy727 remy727 deleted the feature/modal branch July 30, 2024 15:59
@kirillplatonov
Copy link
Collaborator

Published v2.2.0 with latest updates: https://github.com/baoagency/polaris_view_components/releases/tag/v2.2.0

@remy727
Copy link
Contributor Author

remy727 commented Jul 30, 2024

Great. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants