feat: allow to set a empty state for index table #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sifthedog
commented
Oct 23, 2024
•
sifthedog
commented
- Adds possibility to pass an empty state to index table
sifthedog
force-pushed
the
index-table-with-empty-state
branch
4 times, most recently
from
a3505a3
to
b9cbedb
Compare
sifthedog
commented
Oct 23, 2024
| <tbody> | ||
| <% @data.each do |row| %> | ||
| <%= render Polaris::BaseComponent.new(**row_arguments(row)) do %> | ||
| <% if @data.empty? %> |
There was a problem hiding this comment.
I am too lazy to do this everytime on my app's side
There was a problem hiding this comment.
Perfect motivation to improve it 🙂
|
I plan on making more additions down the road to building my Shopify app. Let me know if contributions are welcome and what needs addressing, @kirillplatonov |
sifthedog
force-pushed
the
index-table-with-empty-state
branch
from
b9cbedb
to
e11d742
Compare
sifthedog
commented
Oct 23, 2024
| @@ -0,0 +1,19 @@ | |||
| <% data = [] %> | |||
| <%= polaris_index_table(data) do |table| %> | |||
| <% table.with_column("Name") do |row| %> | |||
There was a problem hiding this comment.
Left on purpose as a placeholder. To indicate that this is not rendered whenever data is empty
sifthedog
force-pushed
the
index-table-with-empty-state
branch
from
e11d742
to
4198f4a
Compare
sifthedog
force-pushed
the
index-table-with-empty-state
branch
from
4198f4a
to
812e09e
Compare
kirillplatonov
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.