Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dictionary): add some 12-letter words to existing dictionary #102

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ilessing
Copy link
Contributor

addresses issue #97

I was digging through the Github issues for the project looking for a good first timer issue and thought this might help address the only one 12 letter word in the dictionary issue #97

@podfeet
Copy link
Contributor

podfeet commented Sep 30, 2024

I'm not exactly sure how the dictionary entries came to be (and I can't find any documentation on it.) But it makes me ask how you chose the additional 12-letter words. Did you use a "random" word generator? How did you decide how many of them there should be?

In the user guide docs there's a section on doing the maths where Bart walks through how entropy is chosen. In part of it, he talks about the number of words. I'm wondering if we need to look at the maths to decide how many to add?

@ilessing
Copy link
Contributor Author

adding an even dozen seemed appropriate. and chatgpt furnished the actual words.

Prompt was: "can you give me 12 english words of 12 letters each"

@hepabolu hepabolu merged commit 38315c4 into bartificer:main Sep 30, 2024
@hepabolu
Copy link
Contributor

Thanks for the extra words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants