fix: name ownership recipient ens casing sensitivity #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@gareys is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
JFrankfurt
reviewed
Oct 16, 2024
JFrankfurt
reviewed
Oct 16, 2024
JFrankfurt
approved these changes
Oct 18, 2024
kirkas
approved these changes
Oct 18, 2024
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* fix: name ownership recipient ens casing sensitivity * use toLowerCase instead of toLocaleLowerCase
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* fix: name ownership recipient ens casing sensitivity * use toLowerCase instead of toLocaleLowerCase
chrischang
pushed a commit
to chrischang/web
that referenced
this pull request
Jan 15, 2025
* fix: name ownership recipient ens casing sensitivity * use toLowerCase instead of toLocaleLowerCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
When you type in an ens or basename in the search input on the ownership change modal, it was case sensitive.
So
Garey.base.ethwouldn't resolve, butgarey.base.ethwould resolve.This change validates the ens name against
inputValue.toLocaleLowerCase()and now the ens will resolve appropriately without casing sensitivity.Notes to reviewers
How has it been tested?
Locally tested, see screenshots.