Chore/update next 15 #1756
Merged
Chore/update next 15 #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
kirkas
previously approved these changes
Feb 12, 2025
Closed
cb-heimdall
dismissed
kirkas’s stale review
Approved review 2613145324 from kirkas is now dismissed due to new commit. Re-request for approval.
brendan-defi
commented
Feb 12, 2025
| @@ -36,9 +36,6 @@ const baseConfig = { | |||
|
|
|||
| // Enable strict mode in development | |||
| reactStrictMode: !isProdEnv, | |||
|
|
|||
| // Minify for production builds | |||
| swcMinify: false, | |||
There was a problem hiding this comment.
no longer valid property in next config
brendan-defi
commented
Feb 12, 2025
| @@ -35,7 +35,7 @@ body { | |||
| height: 100%; | |||
| margin: 0; | |||
| min-height: 100vh; | |||
| font-family: '__coinbaseDisplay_7118f1'; | |||
There was a problem hiding this comment.
outdated font reference, replaced with var
brendan-defi
commented
Feb 13, 2025
| @@ -5,6 +5,10 @@ module.exports = { | |||
| 'plugin:react/jsx-runtime', | |||
| 'eslint-config-prettier', | |||
| ], | |||
| parserOptions: { | |||
There was a problem hiding this comment.
resolves build issue:
Error while loading rule '@typescript-eslint/no-unsafe-argument': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
➤ YN0000: Parser: /home/runner/work/web/web/apps/web/node_modules/eslint-config-next/node_modules/@typescript-eslint/parser/dist/index.js
➤ YN0000: Occurred while linting /home/runner/work/web/web/apps/web/app/(base-org)/(root)/page.tsx
There was a problem hiding this comment.
@kirkas not sure why I get this build error now, but any issue with this addition?
brendan-defi
commented
Feb 13, 2025
| export type MappedDiscountData = { | ||
| [key in Discount]?: DiscountData; | ||
| }; | ||
| export type MappedDiscountData = Partial<Record<Discount, DiscountData>>; |
There was a problem hiding this comment.
@kirkas not sure why popped up now, but I was getting "unused variable key" error.
i believe my change is equivalent but doesn't introduce the unused variable. would be nice if you could confirm
brendan-defi
commented
Feb 13, 2025
|
|
||
| export function findFirstValidDiscount( | ||
| aggregatedData: MappedDiscountData, | ||
| ): DiscountData | undefined { | ||
| const priorityOrder: Partial<{ [key in Discount]: number }> & { default: 3 } = { | ||
| const priorityOrder: Partial<Record<Discount, number>> & { default: 3 } = { |
There was a problem hiding this comment.
@kirkas same "unused key" error
brendan-defi
commented
Feb 13, 2025
| const validators: { | ||
| [key in ProofTableNamespace]: Record<number, Address>; | ||
| } = { | ||
| const validators: Record<ProofTableNamespace, Record<number, Address>> = { |
There was a problem hiding this comment.
@kirkas same unused key error
brendan-defi
commented
Feb 13, 2025
Comment on lines
-33
to
+34
| [key in DiscountType]?: DiscountValue; | ||
| }; | ||
| export type DiscountTypes = Partial<Record<DiscountType, DiscountValue>>; | ||
|
|
||
| export type PreviousClaims = { | ||
| [key in DiscountType]?: PreviousClaim; | ||
| }; | ||
| export type PreviousClaims = Partial<Record<DiscountType, PreviousClaim>>; |
There was a problem hiding this comment.
@kirkas same unused key error
brendan-defi
requested review from
omkarb,
dschlabach,
abcrane123 and
kirkas
dschlabach
approved these changes
Feb 13, 2025
Closed
kirkas
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?
Locally and with vercel preview
/,/about,/bootcamp,/build,/ecosystem,/jobs,/third-party-cookies/names,/name/shrektested claiming a basename
