Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array bounds check in tutorial code example #1757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avorylli
Copy link

Problem:
Array index out of bounds error in getAllLocks() function due to incorrect loop condition

Solution:
Changed array iteration from i <= length to i < length

Impact:

  • Prevents runtime panic (0x32)
  • Matches Solidity best practices
  • Improves tutorial accuracy

Copy link

vercel bot commented Feb 12, 2025

@avorylli is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:25pm

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants