fix: make sure args to echo are quoted
#1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `kamal build pull` (or any action that internally calls that like `kamal setup`, `kamal deploy`, `kamal redeploy`, etc) I would get this line: ``` DEBUG [c035c395] Command: /usr/bin/env mkdir -p .kamal && echo [2025-02-07T13:42:50Z] [EMAIL] Pulled image with version f9d2e07307ea435ce6616cb6a15bb25cdddd96ba >> .kamal/PROJECT-audit.log DEBUG [c035c395] zsh:1: no matches found: [2025-02-07T13:42:50Z] ``` The issue was that the argument to echo was not being quoted. With this change the command is now: ``` /usr/bin/env mkdir -p .kamal && echo "[2025-02-07T13:49:23Z] [EMAIL]" "Pulled image with version f9d2e07307ea435ce6616cb6a15bb25cdddd96ba" >> .kamal/PROJECT-audit.log ``` which works just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
kamal build pull(or any action that internally calls that likekamal setup,kamal deploy,kamal redeploy, etc) I would get this line:The issue was that the argument to echo was not being quoted.
With this change the command is now:
which works just fine