-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload tests #1753
Upload tests #1753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece ótimo!!
Deixei alguns comentários e dúvidas.
""" | ||
dataset = Dataset(dataset_id="1") | ||
|
||
dataset.create(if_exists="raise") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui tenta capturar o erro usando pytest.raises
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert [ | ||
"ano,id_municipio,pib,impostos_liquidos,va,va_agropecuaria,va_industria,va_servicos,va_adespss" | ||
] == cols |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Porque aqui a lista tem apenas uma string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ajustar
"Colocar uma vírgula no csv_delimiter que o retorno se torna ['ano', 'id_municipio', 'pib', 'impostos_liquidos', 'va', 'va_agropecuaria', 'va_industria', 'va_servicos', 'va_adespss']"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# def test_load_schema_from_api(): | ||
# """ | ||
# Test if return the schema | ||
# """ | ||
# out = table._load_schema_from_api('staging') ## IndexError: list index out of range (backend.py:437) | ||
# ## WARNING | _load_schema_from_api:143 - Table pytest allready exists, replacing schema! | ||
# | ||
# assert isinstance(out, list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acho que pode remover esse testes comentado
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ajustar
usar pytest.mark.skip(reason=' ')
PR com os ajustes que o @aspeddro comentou
Code coverage até agora: (13/01/2025 18:30)
Code Coverage até agora: (14/01/2023 02:13)
Coverage final: